[WIP] PHP 8.5 release page #1454
Draft
+620
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Regression report for commit 95c7f62 is at https://web-php-regression-report-pr-1454.preview.thephp.foundation |
|
🚀 Preview for commit 95c7f62 can be found at https://web-php-pr-1454.preview.thephp.foundation |
TimWolla
reviewed
Sep 26, 2025
TimWolla
reviewed
Oct 1, 2025
vudaltsov
reviewed
Oct 3, 2025
vudaltsov
reviewed
Oct 3, 2025
TimWolla
reviewed
Oct 3, 2025
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
TimWolla
reviewed
Oct 4, 2025
Comment on lines
+382
to
+388
| $upcomingRelease = null; | ||
| foreach ($php as $key => $version) { | ||
| if ($version['state'] === 'upcoming') { | ||
| $upcomingRelease = $version; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not a good example, because this could just be array_find().
Comment on lines
+409
to
+414
| $upcomingRelease = array_first( | ||
| array_filter( | ||
| $php, | ||
| static fn($version) => $version['state'] === 'upcoming' | ||
| ) | ||
| ); |
Comment on lines
306
to
358
| <div class="php8-compare__main"> | ||
| <div class="php8-compare__block example-contents"> | ||
| <div class="php8-compare__label">PHP < 8.5</div> | ||
| <div class="php8-code phpcode"> | ||
| <?php highlight_php_trimmed( | ||
| <<<'PHP' | ||
| $sh = curl_share_init(); | ||
| curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS); | ||
| curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT); | ||
|
|
||
| $ch1 = curl_init('https://php.net/'); | ||
| curl_setopt($ch1, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch1); | ||
|
|
||
| $ch2 = curl_init('https://thephp.foundation/'); | ||
| curl_setopt($ch2, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch2); | ||
|
|
||
| curl_share_close($sh); | ||
|
|
||
| curl_close($ch1); | ||
| curl_close($ch2); | ||
| PHP | ||
|
|
||
| ); ?> | ||
| </div> | ||
| </div> | ||
| <div class="php8-compare__arrow"></div> | ||
| <div class="php8-compare__block example-contents" style="display: table;"> | ||
| <div class="php8-compare__label php8-compare__label_new">PHP 8.5</div> | ||
| <div class="php8-code phpcode" style="display: table-cell;"> | ||
| <?php highlight_php_trimmed( | ||
| <<<'PHP' | ||
| $sh = curl_share_init_persistent([ | ||
| CURL_LOCK_DATA_DNS, | ||
| CURL_LOCK_DATA_CONNECT | ||
| ]); | ||
|
|
||
| $ch1 = curl_init('https://php.net/'); | ||
| curl_setopt($ch1, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch1); | ||
|
|
||
| $ch2 = curl_init('https://thephp.foundation/'); | ||
| curl_setopt($ch2, CURLOPT_SHARE, $sh); | ||
| curl_exec($ch2); | ||
|
|
||
| curl_close($ch1); | ||
| curl_close($ch2); | ||
| PHP | ||
| ); ?> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
This comparison is not really meaningful to understand what has changed. At least some explanation is necessary. curl_close() should be removed in all cases, since it is useless with 8.0 and deprecated with 8.5.
Comment on lines
+240
to
+251
| #[DataProvider('subtractionProvider')] | ||
| public function testSubtraction( | ||
| int $minuend, | ||
| int $subtrahend, | ||
| int $result | ||
| ): void | ||
| { | ||
| $this->assertSame( | ||
| $result, | ||
| Calculator::subtract($minuend, $subtrahend) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This should be kept in sync with the 8.5 version. Unfortunately the 8.5 version can't yet use PHPUnit, since sebastianbergmann/phpunit#6136 is not implemented yet. So both should use some “generic test framework”.
TimWolla
reviewed
Oct 4, 2025
TimWolla
reviewed
Oct 5, 2025
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
TimWolla
reviewed
Oct 5, 2025
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
TimWolla
reviewed
Oct 9, 2025
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
TimWolla
reviewed
Oct 12, 2025
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
TimWolla
reviewed
Oct 14, 2025
1 task
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
bkosun
reviewed
Oct 20, 2025
| <div class="php8-code phpcode"> | ||
| <?php highlight_php_trimmed( | ||
| <<<'PHP' | ||
| $components = parse_url("https://php.net/releases/8.5/en.php"); |
There was a problem hiding this comment.
Suggested change
| $components = parse_url("https://php.net/releases/8.5/en.php"); | |
| $components = parse_url('https://php.net/releases/8.5/en.php'); |
To match the coding style in the other samples, single quotes would be preferable.
| <<<'PHP' | ||
| use Uri\Rfc3986\Uri; | ||
|
|
||
| $uri = new Uri("https://php.net/releases/8.5/en.php"); |
There was a problem hiding this comment.
Suggested change
| $uri = new Uri("https://php.net/releases/8.5/en.php"); | |
| $uri = new Uri('https://php.net/releases/8.5/en.php'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://web-php-pr-1454.preview.thephp.foundation/releases/8.5/en.php